From c751f3f5900c17d41bce9022297b38bc67cd5f28 Mon Sep 17 00:00:00 2001 From: Geoffrey Allott Date: Sat, 6 Mar 2021 11:33:15 +0000 Subject: [PATCH] rename game_state -> game_actions and fix clippy lints --- src/client.rs | 9 ++++++--- src/dealer.rs | 2 +- src/server.rs | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/client.rs b/src/client.rs index dd11589..e9b38d1 100644 --- a/src/client.rs +++ b/src/client.rs @@ -60,7 +60,7 @@ impl ConnectionState { ClientState::LoggedIn { username, state: LoggedInState::InGame { ref mut game } } if game.id() == id => { let id = game.id(); let from = game.actions_len(); - match self.server.game_state(id, from).await { + match self.server.game_actions(id, from).await { Ok(actions) => { let actions_view: Vec<_> = actions.iter().map(|action| action.view_for(username)).collect(); for action in actions { @@ -149,7 +149,10 @@ impl ConnectionState { Err(err) => ServerMessage::CreateGameFailure { reason: err.to_string() }, }, (&mut ClientState::LoggedIn { username, .. }, ClientMessage::JoinGame { id }) => { - match (self.server.game_summary(id).await, self.server.game_state(id, 0).await, self.server.game_seed(id).await) { + let summary = self.server.game_summary(id).await; + let actions = self.server.game_actions(id, 0).await; + let seed = self.server.game_seed(id).await; + match (summary, actions, seed) { (Ok(summary), Ok(actions), Ok(seed)) => { let actions_view = actions.iter().map(|action| action.view_for(username)).collect(); let mut game = Game::new(summary.clone(), seed); @@ -181,7 +184,7 @@ impl ConnectionState { }, Ok(ActionStatus::Interrupted) => { debug!("Action {:?} was interrupted - updating game state", action); - match self.server.game_state(id, len).await { + match self.server.game_actions(id, len).await { Ok(actions) => { for new_action in actions { if let Err(err) = game.take_action(new_action) { diff --git a/src/dealer.rs b/src/dealer.rs index 9dece12..13d6a69 100644 --- a/src/dealer.rs +++ b/src/dealer.rs @@ -57,7 +57,7 @@ impl Dealer { info!("Dealer is retrieving updates for game {}", id); 'retrieve_updates: loop { let from = self.dealer.game.actions_len(); - let actions = self.server.game_state(id, from).await?; + let actions = self.server.game_actions(id, from).await?; info!("Got {} actions for game {}", actions.len(), id); for action in actions { debug!("Taking action: {:?}", action); diff --git a/src/server.rs b/src/server.rs index 18c56a4..ab076b6 100644 --- a/src/server.rs +++ b/src/server.rs @@ -203,7 +203,7 @@ impl ServerState { Ok(summaries) } - pub async fn game_state(&mut self, id: i64, from: usize) -> RedisResult> { + pub async fn game_actions(&mut self, id: i64, from: usize) -> RedisResult> { let key = game_actions_key(id); let actions: Vec> = self.redis.lrange(&key, from as isize, -1).await?; Ok(actions.into_iter().map(AsJson::get).collect()) -- 2.34.1